Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Postgres as ChannelMessageStore: use DELETE ... RETURNING to make polling a single operation #8760

Closed
joshiste opened this issue Oct 11, 2023 · 1 comment
Closed

Using Postgres as ChannelMessageStore: use DELETE ... RETURNING to make polling a single operation #8760

joshiste opened this issue Oct 11, 2023 · 1 comment
Labels
in: jdbc type: enhancement
Milestone
6.2.0-RC1

Comments

@joshiste
Copy link
Contributor

joshiste commented Oct 11, 2023 •
edited

Performance using Postrges was greatly improved with the fix from #8711.

But looking at our database performance view I think there is still room to improve.
We could use the DELETE ... RETURNING clause to make this a single statement operation.
The select and delete statements are still the biggest contributors to wait time for polling.

I'd be happy to contribute a PR for this, but first like to discuss wether you'd accept it.
@joshiste joshiste added status: waiting-for-triage The issue need to be evaluated and its future decided type: enhancement labels Oct 11, 2023
@artembilan
Copy link
Member

Sure!
Let's see what we can do with this feature!

I guess we may introduce a new class PostgresChannelMessageStore extends JdbcChannelMessageStore and override respective methods.

Here is our contribution guidelines: https://github.com/spring-projects/spring-integration/blob/main/CONTRIBUTING.adoc

@artembilan artembilan added in: jdbc and removed status: waiting-for-triage The issue need to be evaluated and its future decided labels Oct 11, 2023
@artembilan artembilan added this to the Backlog milestone Oct 11, 2023
joshiste added a commit to joshiste/spring-integration that referenced this issue Oct 11, 2023
@joshiste
spring-projectsGH-8760 PostgresJdbcChannelMessageStore using `DELETE …
459f163 
…... RETURNING`

Fixes spring-projects#8760

* Add PostgresJdbcChannelMessageStore and tests
@joshiste joshiste mentioned this issue Oct 11, 2023
Closed
joshiste added a commit to joshiste/spring-integration that referenced this issue Oct 12, 2023
@joshiste
spring-projectsGH-8760 PostgresJdbcChannelMessageStore using `DELETE …
1755cc6 
…... RETURNING`

Fixes spring-projects#8760

* Add PostgresJdbcChannelMessageStore and tests
@artembilan artembilan modified the milestones: Backlog, 6.2.0-RC1 Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: jdbc type: enhancement
Projects
None yet
Milestone
6.2.0-RC1
Development

Successfully merging a pull request may close this issue.

GH-8760 PostgresJdbcChannelMessageStore using DELETE ... RETURNING joshiste/spring-integration
2 participants
@artembilan @joshiste