INT-3829: Care about @Profile on the @Bean
#1571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: https://jira.spring.io/browse/INT-3829 Alongside with the `@Bean` definition we can use for example `@Profile` `@Conditional` annotation. And the final bean won't be populated to the context. Previously the `MessagingAnnotationPostProcessor` did take care about that infrastructure outcome, hence we ended up with the `NoSuchBeanDefinitionException` * Add appropriate `try...catch(NoSuchBeanDefinitionException)` to the `AbstractMethodAnnotationPostProcessor` and `InboundChannelAdapterAnnotationPostProcessor` to skip further endpoint processing if there is the target bean by the condition reason.
artembilan
force-pushed
the
INT-3829
branch
from
b29b4f4
to
4fcca8c
Compare
| catch (NoSuchBeanDefinitionException e) { | ||
| // Skip the @Bean for farther endpoint processing. | ||
| // Mainly by the @Conditional reason. | ||
| return null; |
There was a problem hiding this comment.
I think we should add a DEBUG log here - just in case, in future, it's some other bean that's missing (not the @Bean).
It's ok in the abstract class because we're only looking for the @Bean there (instead of the more general create... method). However, it won't hurt to add a DEBUG (or TRACE) log there too.
|
Pushed |
|
Polishing here: garyrussell@82f6f51 |
|
Merged as c23aa70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-3829
Alongside with the
@Beandefinition we can use for example@Profile@Conditionalannotation.And the final bean won't be populated to the context.
Previously the
MessagingAnnotationPostProcessordid take care about that infrastructure outcome,hence we ended up with the
NoSuchBeanDefinitionExceptiontry...catch(NoSuchBeanDefinitionException)to theAbstractMethodAnnotationPostProcessorandInboundChannelAdapterAnnotationPostProcessorto skip further endpoint processing if there is the target beanby the condition reason.