Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CacheRequestHandlerAdvice #2105

Closed
wants to merge 3 commits into from

Conversation

artembilan
Copy link
Member

@artembilan artembilan commented Mar 31, 2017

  • Fix AbstractMessageProcessingTransformer to react for the
    AbstractIntegrationMessageBuilder invocation result and don't wrap it
    into the Message
  • Demonstrate functionality in the CacheRequestHandlerAdviceTests

@artembilan
Copy link
Member Author

We may reconsider priority for this feature.
There might be some obstacles doing it existing CacheInterceptor way: https://stackoverflow.com/questions/55073263/ehcache-throwing-notserializableexception-when-moving-to-spring-boot-2

@artembilan artembilan changed the title [DO NOT MERGE - JUST A POC] Add support for CacheRequestHandlerAdvice Add support for CacheRequestHandlerAdvice Apr 11, 2019
@artembilan
Copy link
Member Author

If this is OK, I'll go ahead with docs.

Thanks

@garyrussell
Copy link
Contributor

LGTM

* Fix `AbstractMessageProcessingTransformer` to react for the
`AbstractIntegrationMessageBuilder` invocation result and don't wrap it
into the `Message`
* Demonstrate functionality in the `CacheRequestHandlerAdviceTests`
@artembilan
Copy link
Member Author

Pushed Docs change.

@garyrussell
Copy link
Contributor

$ ./gradlew clean testAll --parallel
Starting a Gradle Daemon (subsequent builds will be faster)

> Task :spring-integration-core:javadoc
/Users/grussell/Development/spring-integration/spring-integration-core/src/main/java/org/springframework/integration/dsl/HeaderEnricherSpec.java:691: warning: empty <p> tag
         * <p><ul>
           ^
/Users/grussell/Development/spring-integration/spring-integration-core/src/main/java/org/springframework/integration/dsl/HeaderEnricherSpec.java:712: warning: empty <p> tag
         * <p><ul>
           ^
/Users/grussell/Development/spring-integration/spring-integration-core/src/main/java/org/springframework/integration/handler/advice/CacheRequestHandlerAdvice.java:133: warning: no @param for errorHandler
        public void setErrorHandler(CacheErrorHandler errorHandler) {
                    ^

@artembilan
Copy link
Member Author

@garyrussell ,

I think this is the last issue which can make it into our M1: I have just upgraded to just released Spring Security M2.

Thanks

@garyrussell
Copy link
Contributor

Merged as 735e82e with minor doc polishing.

@artembilan artembilan deleted the CachableAdvice branch May 15, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants