INT-4471: PubSubChannel: Add errorHandler warn #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: https://jira.spring.io/browse/INT-4471 * When an `Executor` is not provided, log warn that the provided `ErrorHandler` is ignored. **Cherry-pick to 5.0.x and 4.3.x**
garyrussell
reviewed
May 31, 2018
| else if (this.errorHandler != null) { | ||
| logger.warn("When 'executor' is not provided the 'errorHandler' is ignored and " + | ||
| "exceptions are thrown directly within the sending Thread"); | ||
| } |
There was a problem hiding this comment.
Perhaps include the componentName in the message?
garyrussell
pushed a commit
that referenced
this pull request
May 31, 2018
* INT-4471: PubSubChannel: Add errorHandler warn JIRA: https://jira.spring.io/browse/INT-4471 * When an `Executor` is not provided, log warn that the provided `ErrorHandler` is ignored. **Cherry-pick to 5.0.x and 4.3.x** * * Polish warn message
garyrussell
pushed a commit
that referenced
this pull request
May 31, 2018
* INT-4471: PubSubChannel: Add errorHandler warn JIRA: https://jira.spring.io/browse/INT-4471 * When an `Executor` is not provided, log warn that the provided `ErrorHandler` is ignored. **Cherry-pick to 5.0.x and 4.3.x** * * Polish warn message
|
And cherry-picked to 5.0.x, 4.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-4471
Executoris not provided, log warn that the providedErrorHandleris ignored.Cherry-pick to 5.0.x and 4.3.x