Hide toReactivePublisher() from lambdas
#3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an `IntegrationFlow` is declared via lambda, it is impossible to materialize it as a `Publisher` since we lose a Lambda context and finish with a `NoSuchBeanException` when we would like to inject that `Publisher` * Make `IntegrationFlowDefinition.toReactivePublisher()` as `protected` and expose it on the `IntegrationFlowBuilder` level * Use `Channels` as a singleton: no reason in overhead for its instances * Some code style polishing for `IntegrationFlowDefinition`
garyrussell
suggested changes
Sep 26, 2019
| @@ -129,8 +131,7 @@ public FluxMessageChannelSpec flux(String id) { | |||
| return MessageChannels.flux(id); | |||
| } | |||
|
|
|||
| Channels() { | |||
| super(); | |||
| private Channels() { | |||
There was a problem hiding this comment.
Best to leave super() to avoid empty block complaint from Sonar.
garyrussell
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
IntegrationFlowis declared via lambda, it is impossibleto materialize it as a
Publishersince we lose a Lambda context andfinish with a
NoSuchBeanExceptionwhen we would like to inject thatPublisherIntegrationFlowDefinition.toReactivePublisher()asprotectedand expose it on the
IntegrationFlowBuilderlevelChannelsas a singleton: no reason in overhead for its instancesIntegrationFlowDefinition