Add Reactive TX Manager support #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The feature is ready, but I'd like to have a real test against reactive transaction. Thanks |
artembilan
force-pushed
the
ReactiveTXManager
branch
from
4d7008e
to
acd996c
Compare
artembilan
changed the title
|
I decided to go ahead without testing MongoDB reactive transaction. The support is too involved: we need the latest MongoDB server with replica enabled. Plus we need include the replica key from the server into a connection string. |
|
Sorry hit single comment instead of start review; still reviewing. |
garyrussell
suggested changes
Mar 3, 2020
...rc/main/java/org/springframework/integration/transaction/TransactionHandleMessageAdvice.java
Show resolved
Hide resolved
...n-core/src/main/java/org/springframework/integration/config/ConsumerEndpointFactoryBean.java
Outdated
Show resolved
Hide resolved
* Change `TransactionInterceptorBuilder` and `TransactionHandleMessageAdvice` to reply on a generic `TransactionManager`, so we can configure reactive one as well * Change a `<transactional>` XML element to support a generic `TransactionManager` reference, so we can configure reactive one as well * Support `adviceChain` configuration for the `ReactiveMessageHandler` in the `ConsumerEndpointFactoryBean` * Attemp to apply reactive transaction for the Reactive MongoDB channel adapter
to support transactions we need the latest MongoDb server with replica enabled * Document reactive transactions
artembilan
force-pushed
the
ReactiveTXManager
branch
from
acd996c
to
bdb29d8
Compare
garyrussell
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransactionInterceptorBuilderandTransactionHandleMessageAdviceto replyon a generic
TransactionManager, so we can configure reactive one as well<transactional>XML element to support a genericTransactionManagerreference,so we can configure reactive one as well
adviceChainconfiguration for theReactiveMessageHandlerin theConsumerEndpointFactoryBean