GH-3282: Fix JdbcMetadataStore for DuplicateKeyEx #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: spring-projects#3282 The `INSERT INTO ... SELECT ... FROM ... HAVING` may fail with `DuplicateKeyException` in between transactions. * Catch `DuplicateKeyException` from in the `tryToPutIfAbsent()` and return `0` as a fact of not inserted to let other logic to work as expected. There is no test coverage for this since it is almost impossible to reproduce such a race condition on DB **Cherry-pick to 5.3.x & 5.2.x**
garyrussell
suggested changes
May 20, 2020
| @@ -142,7 +147,7 @@ public String putIfAbsent(String key, String value) { | |||
| //try to insert if does not exists | |||
| int affectedRows = tryToPutIfAbsent(key, value); | |||
| if (affectedRows > 0) { | |||
| //it was not in the table, so we have just inserted it | |||
| //it was not in the table, so we have just inserted it or DuplicateKeyException has been thrown | |||
There was a problem hiding this comment.
? This comment seems wrong; we return 0 on the DKE and go to the else block.
garyrussell
pushed a commit
that referenced
this pull request
May 20, 2020
* GH-3282: Fix JdbcMetadataStore for DuplicateKeyEx Fixes: #3282 The `INSERT INTO ... SELECT ... FROM ... HAVING` may fail with `DuplicateKeyException` in between transactions. * Catch `DuplicateKeyException` from in the `tryToPutIfAbsent()` and return `0` as a fact of not inserted to let other logic to work as expected. There is no test coverage for this since it is almost impossible to reproduce such a race condition on DB **Cherry-pick to 5.3.x & 5.2.x** * * Remove misleading message in the comment sentence
garyrussell
pushed a commit
that referenced
this pull request
May 20, 2020
* GH-3282: Fix JdbcMetadataStore for DuplicateKeyEx Fixes: #3282 The `INSERT INTO ... SELECT ... FROM ... HAVING` may fail with `DuplicateKeyException` in between transactions. * Catch `DuplicateKeyException` from in the `tryToPutIfAbsent()` and return `0` as a fact of not inserted to let other logic to work as expected. There is no test coverage for this since it is almost impossible to reproduce such a race condition on DB **Cherry-pick to 5.3.x & 5.2.x** * * Remove misleading message in the comment sentence
|
And cherry-picked to 5.3.x, 5.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3282
The
INSERT INTO ... SELECT ... FROM ... HAVINGmay fail withDuplicateKeyExceptionin between transactions.DuplicateKeyExceptionfrom in thetryToPutIfAbsent()and return
0as a fact of not inserted to let other logic to workas expected.
There is no test coverage for this since it is almost impossible to
reproduce such a race condition on DB
Cherry-pick to 5.3.x & 5.2.x