GH-3280: NullChannel as reply for void gateways #3292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3280 To properly support a one-way gateway (`void` return type), it is better to ignore any possible replies from downstream instead of unexpected `no output-channel or replyChannel header available` error * Populate a `nullChannel` into a `replyChannel` header for `void` gateway methods when `replyChannel` is not set explicitly * Remove redundant `GatewayProxyFactoryBean.PARSER` in favor of similar `EXPRESSION_PARSER` in the super class * Test and document the feature
garyrussell
suggested changes
May 27, 2020
Co-authored-by: Gary Russell <grussell@vmware.com>
Co-authored-by: Gary Russell <grussell@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3280
To properly support a one-way gateway (
voidreturn type), it isbetter to ignore any possible replies from downstream instead of
unexpected
no output-channel or replyChannel header availableerror
nullChannelinto areplyChannelheaderfor
voidgateway methods whenreplyChannelis not set explicitlyGatewayProxyFactoryBean.PARSERin favor ofsimilar
EXPRESSION_PARSERin the super class