Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3092 Refactor FTP and SFTP outbound specs, handlers #3304

Merged
merged 4 commits into from
Jun 15, 2020

Conversation

deepak5127
Copy link
Contributor

@deepak5127 deepak5127 commented Jun 11, 2020

Following are the changes,

  1. Deprecated SFTP and FTP classes outboundAdapter method which takes RemoteFileTemplate. Instead created new methods in both classes which takes SftpRemoteFileTemplate and FtpRemoteFileTemplate respectively.
  2. Deprecated SftpMessageHandlerSpec's constructor which takes RemoteFileTemplate and added new constructors which takes SftpRemoteFileTemplate
  3. Deprecated FtpMessageHandlerSpec's constructor which takes RemoteFileTemplate and added new constructors which takes FtpRemoteFileTemplate. Deprecated FtpMessageHandler's constructor which takes RemoteFileTemplate and added new constructor with ftpRemoteFileTemplate.
  4. Added new test cases in FtpTests and SftpTests

Fixes #3092

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add your name to the @author list of all the affected classes.

Would you also mind to take a look into the (s)ftp.adoc to be sure that code snippets over there use already an new API.

Great job so far, thank you!

/**
* An {@link SftpMessageHandlerSpec} factory for an outbound channel adapter spec.
* @param sftpRemoteFileTemplate the remote file template.
* @return the spec.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, format JavaDocs properly.
And of course @since 5.4!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@deepak5127
Copy link
Contributor Author

@artembilan Added @author for all the files I have changed. (s)ftp.adoc does not reference any code related to RemoteFileTemplate. Please check all the comments I have incorporated and let me know if I miss something

@@ -30,7 +30,7 @@
*
* @author Artem Bilan
* @author Joaquin Santana
*
* @author Deepak Gunasekaran
* @since 5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be a blank line before @since on the class level JavaDocs. This way the author list is much visible.

@artembilan artembilan merged commit 7cefd53 into spring-projects:master Jun 15, 2020
@artembilan
Copy link
Member

@deepak5127 ,

thank you for contribution; looking forward for more!

@deepak5127
Copy link
Contributor Author

Thanks @artembilan for the guidance. Please also let me know if you have anything you feel I can work on, meanwhile I will check on other open issues.

@artembilan
Copy link
Member

Right. See here:

#3194
#3306

Also there are still a lot of tests which should got to JUnit 5 from their JUnit 4.

@deepak5127 deepak5127 deleted the GH-3092 branch June 15, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor FileTransferringMessageHandler impls and resepctive Java DSL components
2 participants