-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-3092 Refactor FTP and SFTP outbound specs, handlers #3304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add your name to the @author
list of all the affected classes.
Would you also mind to take a look into the (s)ftp.adoc
to be sure that code snippets over there use already an new API.
Great job so far, thank you!
spring-integration-ftp/src/main/java/org/springframework/integration/ftp/dsl/Ftp.java
Show resolved
Hide resolved
...ration-ftp/src/main/java/org/springframework/integration/ftp/outbound/FtpMessageHandler.java
Show resolved
Hide resolved
...ration-ftp/src/main/java/org/springframework/integration/ftp/outbound/FtpMessageHandler.java
Show resolved
Hide resolved
/** | ||
* An {@link SftpMessageHandlerSpec} factory for an outbound channel adapter spec. | ||
* @param sftpRemoteFileTemplate the remote file template. | ||
* @return the spec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, format JavaDocs properly.
And of course @since 5.4
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
@artembilan Added @author for all the files I have changed. (s)ftp.adoc does not reference any code related to RemoteFileTemplate. Please check all the comments I have incorporated and let me know if I miss something |
@@ -30,7 +30,7 @@ | |||
* | |||
* @author Artem Bilan | |||
* @author Joaquin Santana | |||
* | |||
* @author Deepak Gunasekaran | |||
* @since 5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There must be a blank line before @since
on the class level JavaDocs. This way the author list is much visible.
thank you for contribution; looking forward for more! |
Thanks @artembilan for the guidance. Please also let me know if you have anything you feel I can work on, meanwhile I will check on other open issues. |
Following are the changes,
Fixes #3092