-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of the inbound part of Redis Stream support. #3350
Conversation
@artembilan, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some review while you're writing tests...
...n/java/org/springframework/integration/redis/inbound/ReactiveRedisStreamMessageProducer.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/integration/redis/inbound/ReactiveRedisStreamMessageProducer.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/integration/redis/inbound/ReactiveRedisStreamMessageProducer.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/integration/redis/inbound/ReactiveRedisStreamMessageProducer.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/integration/redis/inbound/ReactiveRedisStreamMessageProducer.java
Show resolved
Hide resolved
...n/java/org/springframework/integration/redis/inbound/ReactiveRedisStreamMessageProducer.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/integration/redis/inbound/ReactiveRedisStreamMessageProducer.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/integration/redis/inbound/ReactiveRedisStreamMessageProducer.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/integration/redis/inbound/ReactiveRedisStreamMessageProducer.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/integration/redis/inbound/ReactiveRedisStreamMessageProducer.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/integration/redis/inbound/ReactiveRedisStreamMessageProducer.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
You should have a |
Hi @artembilan, |
...n/java/org/springframework/integration/redis/inbound/ReactiveRedisStreamMessageProducer.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/integration/redis/inbound/ReactiveRedisStreamMessageProducerTests.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/integration/redis/inbound/ReactiveRedisStreamMessageProducer.java
Show resolved
Hide resolved
...n/java/org/springframework/integration/redis/inbound/ReactiveRedisStreamMessageProducer.java
Show resolved
Hide resolved
Hi @artembilan,
I think there is an issue with the |
This commit is for a first review since tests are not yet added.
…g the inbound side, one test turns into an infinite loop and one is not yet implemented. We have to first find the reason of the infinite loop before continuing. Toso
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulling locally for review and possible merge after cleaning up...
Merged as 4ae6b52. Please, pull the latest I'm really looking forward for more tests since we have fixed the problem with connection factory. Thank you for contribution! |
@artembilan thanks for your investigation. |
Hi @akuma8 ! Yes, I think the problem for hanging test suite was really about the second call for the Sure! More tests are welcome! Thank you! |
#3226
This commit is for a first review since tests are not yet added.