INT-2436: JMS channel: bean name for container #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: https://jira.spring.io/browse/INT-2436 The `JmsChannelFactoryBean` creates a `ListenerContainer` internally without any `beanName` propagation. When we rely on a default internal `Executor`, it is created with a default thread name prefix for all the JMS channel instances. It cause a confusion in logs * Set `beanName` for the internal `ListenerContainer` to `this.beanName + ".container"` making its connection with a channel it is associated with and unique thread name prefix * Comment out `allWarningsAsErrors = true` in `build.gradle` for deprecated Kotlin language version `1.3`. Otherwise IDEA doesn't want to build project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-2436
The
JmsChannelFactoryBeancreates aListenerContainerinternallywithout any
beanNamepropagation.When we rely on a default internal
Executor, it is created with adefault thread name prefix for all the JMS channel instances.
It cause a confusion in logs
beanNamefor the internalListenerContainertothis.beanName + ".container"making its connection with a channel it is associated with and unique thread name prefix
allWarningsAsErrors = trueinbuild.gradlefor deprecated Kotlinlanguage version
1.3.Otherwise IDEA doesn't want to build project