Fix dynamic Websocket endpoints for SockJS #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to https://stackoverflow.com/questions/67971467/registration-of-dynamic-websocket-at-application-initialization-time-and-at-runt The SockJS wrapper for dynamic endpoint is not initialized properly. Technically we just don't map to the SockJS service if such one is requested from the `ServerWebSocketContainer` configuration * Postpone the path mapping for the target endpoint until after the `ServerWebSocketContainer` applies all the options into its registration to expose. * Fix `ServerWebSocketContainer` to propagate a default `TaskScheduler` for underlying SockJS Service on the endpoint * Fix `IntegrationDynamicWebSocketHandlerMapping` to deal with path patterns as well, which is the case for the mentioned SockJS wrapper: the SockJS Service is able to handle the rest of the path according its setting and request requirements
* Add Javadoc for new `ServerWebSocketContainer.setSockJsTaskScheduler()` API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://stackoverflow.com/questions/67971467/registration-of-dynamic-websocket-at-application-initialization-time-and-at-runt
The SockJS wrapper for dynamic endpoint is not initialized properly.
Technically we just don't map to the SockJS service if such one is requested from the
ServerWebSocketContainerconfigurationServerWebSocketContainerapplies all the optionsinto its registration to expose.
ServerWebSocketContainerto propagate a defaultTaskSchedulerfor underlying SockJS Service on the endpointIntegrationDynamicWebSocketHandlerMappingto deal with path patterns as well, which is the case for the mentioned SockJS wrapper:the SockJS Service is able to handle the rest of the path according its setting and request requirements