GH-3677: Doc for URL conn customization in FeedCA #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3677 If there is need to have a `URLConnection` customized, the `UrlResource` has to be used instead of plain `URL` injection into the `FeedEntryMessageSource`
garyrussell
reviewed
Nov 16, 2021
src/reference/asciidoc/feed.adoc
Outdated
| @@ -127,3 +127,5 @@ public class FeedJavaApplication { | |||
| } | |||
| ---- | |||
| ==== | |||
|
|
|||
| NOTE: If the connection to the feed needs some customization, e.g. connection and read timeouts, the `org.springframework.core.io.UrlResource` extension with its `customizeConnection(HttpURLConnection)` override has to be used instead of plain `URL` injection into the `FeedEntryMessageSource`. | |||
There was a problem hiding this comment.
Perhaps we could include an example?
garyrussell
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3677
If there is need to have a
URLConnectioncustomized, theUrlResourcehas to be used instead of plain
URLinjection into theFeedEntryMessageSource