GH-8625: Add Duration support for <poller>
#8627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#8625 The duration can be represented in a ISO 8601 format, e.g. `PT10S`, `P1D` etc. The `<poller>` and `@Poller` don't support such a format. * Introduce a `PeriodicTriggerFactoryBean` to accept string values for trigger options and parse them manually before creating the target `PeriodicTrigger` * Use this `PeriodicTriggerFactoryBean` in the `PollerParser` and `AbstractMethodAnnotationPostProcessor` where we parse options for the `PeriodicTrigger` * Modify tests to ensure that feature works * Document the duration option * Add more cross-links into polling docs * Fix typos in the affected doc files * Add `-parameters` for compiler options since SF 6.1 does not support `-debug` anymore for method parameter names discovery
garyrussell
suggested changes
May 22, 2023
...on-core/src/main/java/org/springframework/integration/config/PeriodicTriggerFactoryBean.java
Outdated
Show resolved
Hide resolved
|
|
||
| private static Duration toDuration(String value, TimeUnit timeUnit) { | ||
| if (isDurationString(value)) { | ||
| return Duration.parse(value); |
There was a problem hiding this comment.
Assert that timeUnit is not provided in this case?
There was a problem hiding this comment.
Having time-unit does not cause any ambiguity, so ignoring it as it is also done in the ScheduledAnnotationBeanPostProcessor should be totally OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8625
The duration can be represented in a ISO 8601 format, e.g.
PT10S,P1Detc. The<poller>and@Pollerdon't support such a format.PeriodicTriggerFactoryBeanto accept string values for trigger options and parse them manually before creating the targetPeriodicTriggerPeriodicTriggerFactoryBeanin thePollerParserandAbstractMethodAnnotationPostProcessorwhere we parse options for thePeriodicTrigger-parametersfor compiler options since SF 6.1 does not support-debuganymore for method parameter names discovery