Improve Delayer DSL #8645
Merged
Improve Delayer DSL #8645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move `groupId` option from a `delay()` method arg to the `DelayerEndpointSpec` to make it cleaner from code reading perspective * Expose new DSL method based on just a `DelayerEndpointSpec` for Kotlin &v Groovy * Deprecate multi-arg `delay()` methods in favor of `Consumer<DelayerEndpointSpec>`-based
garyrussell
suggested changes
Jun 12, 2023
| @@ -297,6 +318,8 @@ public IntegrationPatternType getIntegrationPatternType() { | |||
|
|
|||
| @Override | |||
| protected void doInit() { | |||
| Assert.notNull(this.messageGroupId, "The 'messageGroupId' must be provided"); | |||
There was a problem hiding this comment.
Either "A 'messageGroupId'..." or "The 'messageGroupId' property..."
| @@ -126,6 +130,14 @@ public class DelayHandler extends AbstractReplyProducingMessageHandler implement | |||
|
|
|||
| private long retryDelay = DEFAULT_RETRY_DELAY; | |||
|
|
|||
| /** | |||
| * Construct an instance with default options. | |||
| * The {@link #messageGroupId} must be provided then via setter. | |||
There was a problem hiding this comment.
Suggested change
| * The {@link #messageGroupId} must be provided then via setter. | |
| * The {@link #messageGroupId} must then be provided via the setter. |
Comment on lines
564
to
567
| @Deprecated("since 6.2", | ||
| ReplaceWith("""delay { | ||
| messageGroupId(groupId) | ||
| }""")) |
| delay { | ||
| messageGroupId 'delayGroup' | ||
| defaultDelay 100 | ||
| } |
garyrussell
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
groupIdoption from adelay()method arg to theDelayerEndpointSpecto make it cleaner from code reading perspectiveDelayerEndpointSpecfor Kotlin &v Groovydelay()methods in favor ofConsumer<DelayerEndpointSpec>-based