-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Executor instead of ThreadFactory for DebeziumMP #8646
Executor instead of ThreadFactory for DebeziumMP #8646
Conversation
Related to spring-projects#8642 For consistency with other Spring requirements and realignment with virtual threads, it is better to require a `TaskExecutor` injection instead of `ThreadFactory` * Fix `DebeziumMessageProducer` to rely on a `TaskExecutor` API instead of `ThreadFactory` and `ExecutorService`
@@ -213,19 +202,6 @@ protected void doStop() { | |||
} | |||
} | |||
|
|||
@Override | |||
public void destroy() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't you supposed to gracefully stop the task executor on exit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See a destroy()
impl in the super class. It does call that stop();
for us.
@artembilan, |
As far as I know that's the move Spring Framework (provides a Well, the |
Ok, LGTM |
Related to #8642
For consistency with other Spring requirements and realignment with virtual threads, it is better to require a
TaskExecutor
injection instead ofThreadFactory
DebeziumMessageProducer
to rely on aTaskExecutor
API instead ofThreadFactory
andExecutorService