GH-8664: Do not use broken observeWithContext()
#8665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#8664 When an `Observation` is turned to `NoopObservation`, the `observeWithContext()` fails with `ClassCastException` since `NoopObservation` serves just plain `Context` not the one we supplied * Fix `MessagingGatewaySupport.sendAndReceiveWithObservation()` same way as it is in version `6.0.x` * Modify `IntegrationObservabilityZipkinTests` to reject some `Observation` via `observationPredicate()` configuration **Cherry-pick to `6.1.x`**
|
This is just a workaround for the current Micrometer version. |
garyrussell
reviewed
Jun 29, 2023
...tion-core/src/main/java/org/springframework/integration/gateway/MessagingGatewaySupport.java
Show resolved
Hide resolved
garyrussell
approved these changes
Jul 12, 2023
garyrussell
pushed a commit
that referenced
this pull request
Jul 12, 2023
Fixes #8664 When an `Observation` is turned to `NoopObservation`, the `observeWithContext()` fails with `ClassCastException` since `NoopObservation` serves just plain `Context` not the one we supplied * Fix `MessagingGatewaySupport.sendAndReceiveWithObservation()` same way as it is in version `6.0.x` * Modify `IntegrationObservabilityZipkinTests` to reject some `Observation` via `observationPredicate()` configuration **Cherry-pick to `6.1.x`**
|
...and cherry-picked to 6.1.x as 41f41ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8664
When an
Observationis turned toNoopObservation, theobserveWithContext()fails withClassCastExceptionsinceNoopObservationserves just plainContextnot the one we suppliedMessagingGatewaySupport.sendAndReceiveWithObservation()same way as it is in version6.0.xIntegrationObservabilityZipkinTeststo reject someObservationviaobservationPredicate()configurationCherry-pick to
6.1.x