INT-3147: (3167,3173,1941) Improve MetadataStore #928
Conversation
| @@ -82,17 +83,19 @@ | |||
| * If the feed URL has a protocol other than http*, consider providing a custom implementation of the | |||
| * {@link FeedFetcher} via the alternate constructor. | |||
| */ | |||
| public FeedEntryMessageSource(URL feedUrl) { | |||
| this(feedUrl, new HttpURLFeedFetcher(HashMapFeedInfoCache.getInstance())); | |||
| public FeedEntryMessageSource(URL feedUrl, String metadataKey) { | |||
There was a problem hiding this comment.
Needs migration guide entry - constructor change.
There was a problem hiding this comment.
Right. Sorry: forgot to mark is as breaking change
And there is need to add more docs.
I don't know maybe @ghillert will take care of it in the https://jira.springsource.org/browse/INT-3148
There was a problem hiding this comment.
I guess we also need to warn that the existing metadata will be invalid.
There was a problem hiding this comment.
Sure! The Migration Guide note.
|
Pushed |
|
Pushed polishing after rebase. |
|
Please move package |
|
Np. Will be done. |
|
I was going to issue a PR, but realized it would impact this one. |
Previously, `MetadataStore` couldn't be configured for Twitter Adapters - only global one. The `metadataKey` was generated automatically with 'difficult' value * Register all `MessageSource` for `SourcePollingChannelAdapter` as beans with id based on adapter id and prefix '.source' (INT-3147) * Polishing parser to get rid of explicit `MessageSource` beans. (INT-3147) * Make Feed and Twitter adapters `id` attribute as required - now it presents a `metadataKey` for `MetadataStore` (INT-3147) * Add to Twitter adapters a reference attribute for `MetadataStore` (INT-3173) * Add Twitter adapters `poll-skip-period` attribute (INT-3167) * Add and implement `MetadataStore#remove` (INT-1941) * Make `MetadataStore` as `@ManagedResource` (INT-1941) * Polishing tests JIRAs: https://jira.springsource.org/browse/INT-3147 https://jira.springsource.org/browse/INT-3167 https://jira.springsource.org/browse/INT-3173 https://jira.springsource.org/browse/INT-1941
* add domain suffix to `metadataKey` * change contract of `MetadataStore.remove` * remove timeout window from `AbstractTwitterMessageSource` * polishing and fix `SearchReceivingMessageSourceWithRedisTests`
|
Pushed fix for 'metadata' package tangle |
| * return the previous value associated with <tt>key</tt>, or | ||
| * <tt>null</tt> if there was no mapping for <tt>key</tt>. | ||
| */ | ||
| @ManagedAttribute |
There was a problem hiding this comment.
These should be @ManagedOperations
There was a problem hiding this comment.
Sure! Thanks
Will be pushed after other feedbacks
|
Building now; will merge after; doc polish here Let me know if you have issues with any of the polish |
|
Merged |
Previously,
MetadataStorecouldn't be configured for Twitter Adapters, only global one.The
metadataKeywas generated automatically with 'difficult' valueMessageSourceforSourcePollingChannelAdapteras beans with id based on adapter id and prefix '.source' (INT-3147)
MessageSourcebeans. (INT-3147)idattribute as required -now it presents a
metadataKeyforMetadataStore(INT-3147)MetadataStore(INT-3173)poll-skip-periodattribute (INT-3167)MetadataStore#remove(INT-1941)MetadataStoreas@ManagedResource(INT-1941)JIRAs:
https://jira.springsource.org/browse/INT-3147
https://jira.springsource.org/browse/INT-3167
https://jira.springsource.org/browse/INT-3173
https://jira.springsource.org/browse/INT-1941