Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FallbackBatchErrorHandler - Consider Seeking and Exiting Retries When Container is Paused #2742

Closed
garyrussell opened this issue Jul 13, 2023 · 0 comments · Fixed by #2743
Closed

FallbackBatchErrorHandler - Consider Seeking and Exiting Retries When Container is Paused #2742

garyrussell opened this issue Jul 13, 2023 · 0 comments · Fixed by #2743
Labels
type: enhancement
Milestone
3.0.9

Comments

@garyrussell
Copy link
Contributor

Currently, the FBEH retries internally (pausing and polling the consumer) until retries are exhausted.

There is a use case where the user might want to pause deliveries during the retry attempts, by pausing the container.

It should be possible to detect that a container pause has been requested, seek the batch records and exit the retry loop under this condition.

See the discussion here: #2739 (comment)
@garyrussell garyrussell added this to the Backlog milestone Jul 13, 2023
@garyrussell garyrussell mentioned this issue Jul 13, 2023
Closed
antonio-tomac added a commit to antonio-tomac/spring-kafka that referenced this issue Jul 14, 2023
@antonio-tomac
spring-projectsGH-2742: Exit batch retries when container is paused
ed02520
@antonio-tomac antonio-tomac mentioned this issue Jul 14, 2023
Merged
antonio-tomac added a commit to antonio-tomac/spring-kafka that referenced this issue Jul 14, 2023
@antonio-tomac
spring-projectsGH-2742: fix code style spaces
9668bab
antonio-tomac added a commit to antonio-tomac/spring-kafka that referenced this issue Jul 14, 2023
@antonio-tomac
spring-projectsGH-2742: better method name for what it does
c6fe748
garyrussell pushed a commit that referenced this issue Jul 16, 2023
@antonio-tomac
GH-2742: Exit batch retries when container is paused (#2743)
b5506ee 
* GH-2742: Exit batch retries when container is paused

* GH-2742: fix code style spaces

* GH-2742: better method name for what it does
@garyrussell garyrussell modified the milestones: Backlog, 3.0.9 Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
3.0.9
Development

Successfully merging a pull request may close this issue.

GH-2742: Exit batch retries when container is paused antonio-tomac/spring-kafka
1 participant
@garyrussell