You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CommonDelegatingErrorHandler should implement CommonErrorHandler.handleOne()
This implementation should be the same as the other handle methods - Finding a delegate CommonErrorHandler, then call it's .handleOne() method. If a delegate cannot be found, use the defaultErrorHandler
Current Behavior
Currently this method is not implemented, and the default behaviour from the CommonErrorHandler interface is to log an error and return true, indicating the error was "handled"
Context
This issue came up when trying to use the DefaultErrorHandler with seekAfterError set to false
The value of seekAfterError is used for the return of the DefaultErrorHandler.seeksAfterHandling() method, the value of which is used to decide whether CommonErrorHandler.handleRemaining() vs CommonErrorHandler.handleRemaining() is called when an error is thrown by a non-batch Listener
I wish to be able to use the seekAfterError behaviour in the DefaultErrorHandler, while also using the CommonDelegatingErrorHandler to delegate between different DefaultErrorHandler's
The text was updated successfully, but these errors were encountered:
Fixes: #3227
* Implement handleOne() in `CommonDelegatingErrorHandler`
* Add tests for handle methods in `CommonDelegatingErrorHandler`
* Add tests for the new `handleOne()` method, as well as a test for `handleOtherException()`
* Checkstyle fixes
(cherry picked from commit 4e06c2c)
Fixes: #3227
* Implement handleOne() in `CommonDelegatingErrorHandler`
* Add tests for handle methods in `CommonDelegatingErrorHandler`
* Add tests for the new `handleOne()` method, as well as a test for `handleOtherException()`
* Checkstyle fixes
(cherry picked from commit 4e06c2c)
Expected Behavior
CommonDelegatingErrorHandler
should implementCommonErrorHandler.handleOne()
This implementation should be the same as the other
handle
methods - Finding a delegateCommonErrorHandler
, then call it's.handleOne()
method. If a delegate cannot be found, use thedefaultErrorHandler
Current Behavior
Currently this method is not implemented, and the default behaviour from the
CommonErrorHandler
interface is to log an error and return true, indicating the error was "handled"Context
This issue came up when trying to use the
DefaultErrorHandler
withseekAfterError
set tofalse
The value of
seekAfterError
is used for the return of theDefaultErrorHandler.seeksAfterHandling()
method, the value of which is used to decide whetherCommonErrorHandler.handleRemaining()
vsCommonErrorHandler.handleRemaining()
is called when an error is thrown by a non-batch ListenerI wish to be able to use the
seekAfterError
behaviour in theDefaultErrorHandler
, while also using theCommonDelegatingErrorHandler
to delegate between differentDefaultErrorHandler
'sThe text was updated successfully, but these errors were encountered: