Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve property placeholders in EmbeddedKafka topics #555

Closed
zacholauson opened this issue Feb 3, 2018 · 0 comments
Closed

Resolve property placeholders in EmbeddedKafka topics #555

zacholauson opened this issue Feb 3, 2018 · 0 comments

Comments

@zacholauson
Copy link
Contributor

zacholauson commented Feb 3, 2018 •
edited
Loading

I'm working on a project where we are configuring all of our topics in property files, so our tests have to know about the contents of the property files to configure the correct topics. The alternative to this is to use @TestPropertySource to override our topic properties, but we have a lot of topics, so it's not that convenient.

Ideally the topic attribute of @EmbeddedKafka would be able to accept and resolve property placeholders.

Example:

@EmbeddedKafka(topics = { "${kafka.topic.one}", "${kafka.topic.two}" })
zacholauson added a commit to zacholauson/spring-kafka that referenced this issue Feb 3, 2018
@zacholauson
spring-projectsGH-555: Resolve property placeholders in EmbeddedKafka…
0cafeb5 
… topics

Fixes spring-projects#555

* Update EmbeddedKafkaContextCustomizer to resolve property placeholders
* Update KafkaStreamsTests to use topic from property
* Add property resolving details to EmbeddedKafka javadoc and testing.adoc
@zacholauson zacholauson mentioned this issue Feb 3, 2018
Closed
zacholauson added a commit to zacholauson/spring-kafka that referenced this issue Feb 3, 2018
@zacholauson
spring-projectsGH-555: Resolve property placeholders in EmbeddedKafka…
96fec36 
… topics

Fixes spring-projects#555

* Update EmbeddedKafkaContextCustomizer to resolve property placeholders
* Update KafkaStreamsTests to use topic from property
* Add property resolving details to EmbeddedKafka javadoc and testing.adoc
zacholauson added a commit to zacholauson/spring-kafka that referenced this issue Feb 3, 2018
@zacholauson
spring-projectsGH-555: Resolve property placeholders in EmbeddedKafka…
2f1d700 
… topics

Fixes spring-projects#555

* Update EmbeddedKafkaContextCustomizer to resolve property placeholders
* Update KafkaStreamsTests to use topic from property
* Add property resolving details to EmbeddedKafka javadoc and testing.adoc
zacholauson added a commit to zacholauson/spring-kafka that referenced this issue Feb 3, 2018
@zacholauson
spring-projectsGH-555: Resolve property placeholders in EmbeddedKafka…
d2384f7 
… topics

Fixes spring-projects#555

* Update EmbeddedKafkaContextCustomizer to resolve property placeholders
* Update KafkaStreamsTests to use topic from property
* Add property resolving details to EmbeddedKafka javadoc and testing.adoc
zacholauson added a commit to zacholauson/spring-kafka that referenced this issue Feb 3, 2018
@zacholauson
spring-projectsGH-555: Resolve property placeholders in EmbeddedKafka…
520dc4d 
… topics

Fixes spring-projects#555

* Update EmbeddedKafkaContextCustomizer to resolve property placeholders
* Update KafkaStreamsTests to use topic from property
* Add property resolving details to EmbeddedKafka javadoc and testing.adoc
denis554 added a commit to denis554/spring-kafka that referenced this issue Mar 27, 2019
@denis554
GH-555: Resolve PPs in EmbeddedKafka topics
53bf0b1 
Fixes spring-projects/spring-kafka#555

* Update `EmbeddedKafkaContextCustomizer` to resolve property placeholders
* Update `KafkaStreamsTests` to use topic from property
* Add property resolving details to `EmbeddedKafka` javadoc and testing.adoc

* Simple polishing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve property placeholders in EmbeddedKafka topics zacholauson/spring-kafka
1 participant
@zacholauson