Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Kafka client 2.0.0 in branch 2.1.x #780

Closed
bgK opened this issue Aug 14, 2018 · 3 comments
Closed

Backport Kafka client 2.0.0 in branch 2.1.x #780

bgK opened this issue Aug 14, 2018 · 3 comments

Comments

@bgK
Copy link
Contributor

bgK commented Aug 14, 2018

Would it be possible to add support for the Kafka clients 2.0.0 in branch 2.1.x ?

Or do you think branch 2.1.x can work with the 2.0.0 Kafka clients by overriding the dependencies ?

Kafka 2.0.0 has some interesting bug fixes for us, and we'd like to upgrade without necessarily upgrading the rest of the Spring ecosystem.

@garyrussell
Copy link
Contributor

garyrussell commented Aug 14, 2018

Exactly which changes are you looking for?

It has not been tested but it might work.

However, the deprecated blocking APIs (e.g. poll(long)) will still be used (instead of the non-blocking poll(Duration)).

We do not intend to backport support for 2.0.0 to the 2.1 line (non-blocking APIs).

We expect to release the next milestone of 2.2 (including the changes for 2.0.0 non-blocking APIs) next week, with the release due next month or early October.

@bgK
Copy link
Contributor Author

bgK commented Aug 15, 2018

Thanks for your answer. We are mostly interested in the fix for KAFKA-6446 so the producers don't block indefinitely if for some reason the brokers fail to respond with a producerId (It has happened to us with the brokers properly started).

I'll try overriding the dependencies and report back here.

@bgK
Copy link
Contributor Author

bgK commented Aug 16, 2018

Overriding the dependencies to use kafka-clients 2.0.0 seems to work well enough for our purpose, except the embedded Kafka broker due to a hardcoded version number:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants