Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NameAwareAttributes#remove should be case insensitive #548

Closed
0x0000-dot-ru opened this issue Mar 5, 2020 · 1 comment
Closed

NameAwareAttributes#remove should be case insensitive #548

0x0000-dot-ru opened this issue Mar 5, 2020 · 1 comment

Comments

@0x0000-dot-ru
Copy link

According to inherithed javadoc from javax.naming.directory.Attributes this method should be case insenitive. This bug breaks remove attribute logic in org.springframework.ldap.core.DirContextAdapter#update.

https://docs.oracle.com/javase/7/docs/api/javax/naming/directory/Attributes.html#remove(java.lang.String) says
"If the attribute set ignores the character case of its attribute ids, the case of attrID is ignored."
@rwinch
Copy link
Member

rwinch commented Mar 16, 2020

Thanks for the report @0x0000-dot-ru are you interested in submitting a PR?

@rwinch rwinch added the bug label Mar 16, 2020
@rwinch rwinch removed the bug label May 4, 2020
jzheaux added a commit that referenced this issue Feb 4, 2022
@jzheaux
Make NameAwareAttributes#remove Case-insensitive
da79e61 
Closes gh-548
@jzheaux jzheaux closed this as completed in 415cf80 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwinch @0x0000-dot-ru