Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed base not being used for findAll search #469

Closed
wants to merge 1 commit into from

Conversation

dustins
Copy link

@dustins dustins commented Oct 26, 2017

  • added support for getting base from ObjectDirectoryMapper
  • replaced using empty base with defined base

- added support for getting base from ObjectDirectoryMapper
- replaced using empty base with defined base
@rwinch
Copy link
Member

rwinch commented Oct 28, 2017

@dustins Thanks for the PR! Unfortunately we cannot add a method to an interface because this is not passive. Since our next major release is not planned for some time, I'm closing this.

@rwinch rwinch closed this Oct 28, 2017
@pivotal-issuemaster
Copy link

@dustins Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@rwinch rwinch self-assigned this Oct 28, 2017
@pivotal-issuemaster
Copy link

@dustins Thank you for signing the Contributor License Agreement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants