Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for event externalization into AWS SNS and SQS #344

Closed
maciejwalkowiak opened this issue Oct 24, 2023 · 3 comments
Closed

Support for event externalization into AWS SNS and SQS #344

maciejwalkowiak opened this issue Oct 24, 2023 · 3 comments
Assignees
@odrotbohm
Labels
in: event publication registry Event publication registry type: enhancement Major enhanvements, new features
Milestone
1.1 RC2

Comments

@maciejwalkowiak
Copy link
Contributor

In addition to Kafka, AMQP and JMS, Modulith could publish externalized events to AWS services: SQS, SNS and perhaps Kinesis.

This can be implemented either here - using AWS SDK directly - or in Spring Cloud AWS where we could use Spring Cloud AWS infrastructure to configure AWS clients.
@odrotbohm
Copy link
Member

That's a great idea! I unfortunately know too little about the AWS APIs. Would you mind taking a look at KafkaEventExternalizerConfiguration and how it uses KafkaOperations with a DelegatingEventExternalizer? If you can point me to a similar infrastructure API that allows sending arbitrary messages to a target and that I can assume gets autoconfigured on a particular classpath arrangement, I'd be happy to add a module that forwards events to that.

@odrotbohm odrotbohm self-assigned this Oct 27, 2023
@odrotbohm odrotbohm added the meta: waiting for feedback Waiting for feedback of the original reporter label Oct 27, 2023
@maciejwalkowiak maciejwalkowiak mentioned this issue Oct 30, 2023
Closed
@maciejwalkowiak
Copy link
Contributor Author

@odrotbohm I added a PR with SQS and SNS integration. I skipped Kinesis as it has been too long since I've used it and we don't have support for it in Spring Cloud AWS anyway. I am happy to answer any questions :)

odrotbohm pushed a commit that referenced this issue Nov 1, 2023
@maciejwalkowiak @odrotbohm
GH-344 - Support for event externalization into AWS SNS and SQS.
1b83474 
Additional event externalization implementations for AWS SNS and SQS.

Original pull request: GH-350.
odrotbohm added a commit that referenced this issue Nov 1, 2023
@odrotbohm
GH-344 - Polishing.
cdfff4b 
Switch to DelegatingEventExternalizer APIs changed to return CompletableFuture. Imports, formatting. Drop dependencies not needed.
odrotbohm pushed a commit that referenced this issue Nov 1, 2023
@maciejwalkowiak @odrotbohm
GH-344 - Support for event externalization into AWS SNS and SQS.
bdd2a59 
Additional event externalization implementations for AWS SNS and SQS.

Original pull request: GH-350.
odrotbohm added a commit that referenced this issue Nov 1, 2023
@odrotbohm
GH-344 - Polishing.
9587c97 
Switch to DelegatingEventExternalizer APIs changed to return CompletableFuture. Imports, formatting. Drop dependencies not needed.
odrotbohm pushed a commit that referenced this issue Nov 1, 2023
@maciejwalkowiak @odrotbohm
GH-344 - Support for event externalization into AWS SNS and SQS.
f41d337 
Additional event externalization implementations for AWS SNS and SQS.

Original pull request: GH-350.
odrotbohm added a commit that referenced this issue Nov 1, 2023
@odrotbohm
GH-344 - Polishing.
21a8282 
Switch to DelegatingEventExternalizer APIs changed to return CompletableFuture. Imports, formatting. Drop dependencies not needed.
odrotbohm pushed a commit that referenced this issue Nov 2, 2023
@maciejwalkowiak @odrotbohm
GH-344 - Support for event externalization into AWS SNS and SQS.
d95da87 
Additional event externalization implementations for AWS SNS and SQS.

Original pull request: GH-350.
odrotbohm added a commit that referenced this issue Nov 2, 2023
@odrotbohm
GH-344 - Polishing.
e8898c1 
Switch to DelegatingEventExternalizer APIs changed to return CompletableFuture. Imports, formatting. Drop dependencies not needed.
@odrotbohm odrotbohm added in: event publication registry Event publication registry type: enhancement Major enhanvements, new features and removed meta: waiting for feedback Waiting for feedback of the original reporter labels Nov 2, 2023
@odrotbohm odrotbohm added this to the 1.1 RC2 milestone Nov 2, 2023
@odrotbohm
Copy link
Member

PR merged, thanks for the contribution!

@odrotbohm odrotbohm changed the title Publish externalized events to AWS services Support for event externalization into AWS SNS and SQS Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: event publication registry Event publication registry type: enhancement Major enhanvements, new features
Projects
None yet
Milestone
1.1 RC2
Development

Successfully merging a pull request may close this issue.

Publish externalized events to SQS and SNS maciejwalkowiak/spring-modulith
2 participants
@odrotbohm @maciejwalkowiak