Allow primitive type for @Recover method parameter #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leeyohan93 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@leeyohan93 Thank you for signing the Contributor License Agreement! |
artembilan
requested changes
Apr 13, 2022
| @@ -152,7 +165,9 @@ private boolean compareParameters(Object[] args, int argCount, Class<?>[] parame | |||
| if (argument == null) { | |||
| continue; | |||
| } | |||
| if (!parameterTypes[i].isAssignableFrom(argument.getClass())) { | |||
| Class<?> parameterType = parameterTypes[i]; | |||
| parameterType = parameterType.isPrimitive() ? wrappers.get(parameterType) : parameterType; | |||
There was a problem hiding this comment.
I wonder if ClassUtils.resolvePrimitiveIfNecessary(Class<?> clazz) can be used instead...
|
Merged as 4b298b3. thank you for the contribution; looking forward for more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use the primitive type when I specify the Recover method.
But I could only use the wrapped type like below and I simply fixed this part.
I simply fixed this part, so I think you can fix it a better.
Thank you.