Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phoneNumberVerified field is Boolean type #11315

Closed
ziponia opened this issue Jun 1, 2022 · 2 comments
Closed

phoneNumberVerified field is Boolean type #11315

ziponia opened this issue Jun 1, 2022 · 2 comments
Assignees
@sjohnr
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.8.0-M1

Comments

@ziponia
Copy link
Contributor

ziponia commented Jun 1, 2022

spring-security/oauth2/oauth2-core/src/main/java/org/springframework/security/oauth2/core/oidc/OidcUserInfo.java

Lines 252 to 254 in b78a28b

public Builder phoneNumberVerified(String phoneNumberVerified) {
return this.claim(StandardClaimNames.PHONE_NUMBER_VERIFIED, phoneNumberVerified);
}

https://openid.net/specs/openid-connect-core-1_0.html#rfc.section.5.1

According to the documentation, phoneNumberVerified must be of type Boolean.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 1, 2022
@marcusdacoregio marcusdacoregio added the in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) label Jun 1, 2022
@sjohnr
Copy link
Member

sjohnr commented Jun 1, 2022

Thanks for the report, @ziponia! It looks like this method could be deprecated in the 5.8.x branch and a new method with type boolean added. The getter in StandardClaimsAccessor already returns a boolean.

Are you interested in submitting a PR for this?

@sjohnr sjohnr added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 1, 2022
@sjohnr sjohnr added this to the 5.8.x milestone Jun 1, 2022
@ziponia ziponia mentioned this issue Jun 1, 2022
Merged
@ziponia
Copy link
Contributor Author

ziponia commented Jun 1, 2022

@sjohnr

ok! i submitted PR.
If it's not enough, please tell me again

ziponia added a commit to ziponia/spring-security that referenced this issue Jun 2, 2022
@ziponia
Change phoneNumberVerified with type Boolean
964347f 
Closes: spring-projectsgh-11315
sjohnr pushed a commit that referenced this issue Jun 3, 2022
@ziponia @sjohnr
Change phoneNumberVerified with type Boolean
759d799 
Closes: gh-11315
@sjohnr sjohnr closed this as completed in e28fcbf Jun 3, 2022
@sjohnr sjohnr modified the milestones: 5.8.x, 5.8.0-M1 Jun 3, 2022
jgrandja added a commit to spring-projects/spring-authorization-server that referenced this issue Oct 24, 2022
@jgrandja
Use Boolean field for OidcUserInfo.phoneNumberVerified
629e220 
Related spring-projects/spring-security#11315

Closes gh-923
doba16 pushed a commit to doba16/spring-authorization-server that referenced this issue Apr 21, 2023
@jgrandja
Use Boolean field for OidcUserInfo.phoneNumberVerified
c3dbc70 
Related spring-projects/spring-security#11315

Closes spring-projectsgh-923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjohnr sjohnr

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.8.0-M1
Development

No branches or pull requests
4 participants
@sjohnr @marcusdacoregio @spring-projects-issues @ziponia