Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change phoneNumberVerified with type Boolean #11317

Merged

Conversation

ziponia
Copy link
Contributor

@ziponia ziponia commented Jun 1, 2022

Closes: gh-11315

@pivotal-cla
Copy link

@ziponia Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 1, 2022
@pivotal-cla
Copy link

@ziponia Thank you for signing the Contributor License Agreement!

Copy link
Member

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ziponia! Please update the copyright year in the header to 2022 (see contributing.adoc). I have provided some additional feedback inline.

@sjohnr sjohnr added status: duplicate A duplicate of another issue type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 1, 2022
@ziponia ziponia force-pushed the phoneNumberVerified-type-to-boolean branch 2 times, most recently from a1706fa to 0292033 Compare June 1, 2022 17:26
@ziponia ziponia requested a review from sjohnr June 1, 2022 17:28
@rwinch rwinch added this to the 5.8.x milestone Jun 2, 2022
@sjohnr
Copy link
Member

sjohnr commented Jun 2, 2022

Thanks for the updates @ziponia! I have approved this. However, did you see my request to update the copyright year in the header to 2022? If you aren't able to just let me know and I can take care of it.

@sjohnr sjohnr self-assigned this Jun 2, 2022
@ziponia ziponia force-pushed the phoneNumberVerified-type-to-boolean branch from 0292033 to 964347f Compare June 2, 2022 23:33
@ziponia
Copy link
Contributor Author

ziponia commented Jun 2, 2022

sorry @sjohnr! I didn't see the request.
Just updated.

@sjohnr sjohnr merged commit 759d799 into spring-projects:5.8.x Jun 3, 2022
@sjohnr sjohnr modified the milestones: 5.8.x, 5.8.0-M1 Jun 3, 2022
@ziponia ziponia deleted the phoneNumberVerified-type-to-boolean branch June 13, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants