Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch for 6.2.x appears to have been merged with 6.3.x via fast-forward merge with main branch #15016

Closed
dforrest-es opened this issue May 7, 2024 · 2 comments
Assignees
Labels
type: task A general task

Comments

@dforrest-es
Copy link

Describe the bug
I've been keeping an eye on this repository for SAML based changes & noticed odd branch updates on 6.2.x since my last check around April 18th. At the time, the diff stats between 6.2.x & main were 415 commits, 310 files changed, & +29771 -1227 as seen here. Currently (May 7th) it is 45 commits, 28 files changed, & +643 -176 as seen here.

It can also be seen that the 6.2.x branch has 6.3.x changes:

An illustration below shows the 6.2.x branch (pink line) becoming the same as the main branch (purple line) for a period of time between April 21st & 23rd. Of note, orange & teal lines are 6.1.x & 5.8.x respectively.
broken-6 2 x-branch

I assume this was a mistake & has just not been noticed yet. For reference, the commit hashes for 'New 6.2.x branch' is c33afce & for 'Old 6.2.x branch' is 7007ce3.

To Reproduce
None

Expected behavior
None

@dforrest-es dforrest-es added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels May 7, 2024
@marcusdacoregio marcusdacoregio added for: team-attention This ticket should be discussed as a team before proceeding and removed status: waiting-for-triage An issue we've not yet triaged labels May 7, 2024
@marcusdacoregio marcusdacoregio self-assigned this May 7, 2024
@marcusdacoregio marcusdacoregio added type: task A general task and removed type: bug A general bug for: team-attention This ticket should be discussed as a team before proceeding labels May 8, 2024
marcusdacoregio added a commit that referenced this issue May 8, 2024
@marcusdacoregio
Copy link
Contributor

Thank you very much for your report @dforrest-es, that indeed wasn't noticed by the team.

Thanks to the help of @sjohnr, we have now (hopefully) fixed the issue via 08f11f0

Basically, what we did (for future reference) was hard reset the 6.2.x branch to 7007ce3, then soft reset the branch back to the latest commit. Then we reapplied every 6.2.x commit after the fast-forward happened.

We will look for measures to prevent this from happening again.

@dforrest-es
Copy link
Author

@marcusdacoregio, you are very welcome. I am glad to see that empty merge commit from 6.2.x into main after the revert to prevent the reversion commit from breaking main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
Status: No status
Development

No branches or pull requests

2 participants