Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 4.10.2 #6106

Closed
raphaelDL opened this issue Nov 16, 2018 · 3 comments
Closed

Update to Gradle 4.10.2 #6106

raphaelDL opened this issue Nov 16, 2018 · 3 comments

Comments

@raphaelDL
Copy link
Contributor

raphaelDL commented Nov 16, 2018

With current version of Gradle 4.10.1 when I run a task with

./gradlew ...

I get these warnings:

> Configure project :spring-security-aspects The Task.deleteAllActions() method has been deprecated. This is scheduled to be removed in Gradle 5.0.

> Configure project :spring-security-samples-javaconfig-x509 Found slf4j-api dependency but no providers were found. Did you mean to add slf4j-simple? See https://www.slf4j.org/codes.html#noProviders .

What if we do the next?

  1. Upgrade Gradle
    ./gradlew wrapper --gradle-version 4.10.2

  2. Update buildSrc/src/main/groovy/aspectj/AspectJPlugin.groovy

from javaCompileTask.deleteAllActions()
to
javaCompileTask.setActions new ArrayList(0) or javaCompileTask.setActions Arrays.asList()

  1. Update /samples/javaconfig/x509/spring-security-samples-javaconfig-x509.gradle
    Remove compile 'org.slf4j:slf4j-api'
@rwinch
Copy link
Member

rwinch commented Nov 19, 2018

@raphaelDL I am not sure I understand this issue. Did you try to update to Gradle 4.10.2 and it failed? I know there are warnings, but that seems distinct from the subject of Update to Gradle 4.10.2. Can you help me understand please?

@raphaelDL
Copy link
Contributor Author

raphaelDL commented Nov 19, 2018

ohhh I see it now, I think I'm getting it wrong here by I'm mixing issues
I think there's three issues:

-Update Gradle version
-Remove deprecated method buildSrc/src/main/groovy/aspectj/AspectJPlugin.groovy
-Remove unused(?) dependency in sample /samples/javaconfig/x509/spring-security-samples-javaconfig-x509.gradle

My mistake was looking at this as a way to remove all issues when building the project but I failed to recognize that Update to Gradle 4.10.2 does not imply the others.

Given the title, you're right... this issue should cover only updating Gradle, and I should open two more to address the rest.

If there are not other things to consider when updating Gradle, I'd be happy to take this...

@rwinch
Copy link
Member

rwinch commented Nov 19, 2018

Thanks. Yes. We'd love to update to a newer version of Gradle and (in separate PRs as you mentioned) remove the deprecated APIs.

raphaelDL added a commit to raphaelDL/spring-security that referenced this issue Nov 20, 2018
rwinch pushed a commit that referenced this issue Nov 21, 2018
rwinch pushed a commit that referenced this issue Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants