Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move blockhound dependency in 5.1.x to separate branch #7220

Closed
jzheaux opened this issue Aug 5, 2019 · 4 comments
Closed

Move blockhound dependency in 5.1.x to separate branch #7220

jzheaux opened this issue Aug 5, 2019 · 4 comments
Assignees
Labels
in: build An issue in the build type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Aug 5, 2019

Spring Security uses BlockHound to track down blocking issues - it however is not yet GA. As such, it can't be included as a dependency in release artifacts.

To facilitate it's continued usage, it could be moved to a separate git branch that is not a release branch, until BlockHound releases.

An alternative to this task would be to update the release process to remove any milestone dependencies from dependency management before releasing, though this would also mean removing any code that is also dependent on those milestones, which seems cumbersome.

@jzheaux jzheaux added in: build An issue in the build type: enhancement A general enhancement labels Aug 5, 2019
@jzheaux jzheaux added this to the 5.1.6 milestone Aug 5, 2019
@jzheaux jzheaux self-assigned this Aug 5, 2019
jzheaux added a commit that referenced this issue Aug 5, 2019
Since it is not yet GA

Fixes gh-7220
@jzheaux
Copy link
Contributor Author

jzheaux commented Aug 5, 2019

Fixed via 404ad9a

@jzheaux jzheaux closed this as completed Aug 5, 2019
@bsideup
Copy link

bsideup commented Aug 23, 2019

I'm just curious: why do you have testCompile dependencies in the release artifacts?

@jzheaux
Copy link
Contributor Author

jzheaux commented Aug 24, 2019

@bsideup, I don't think we're including testCompile dependencies in release artifacts.

When we do release builds, though, we only pull from release repositories. Because of this, any milestone dependency will fail the build since it can't be located.

Or did I misunderstand your question?

@bsideup
Copy link

bsideup commented Aug 24, 2019

@jzheaux ah, I see. Perhaps you can apply the same "is release" conditional logic to BlockHound then, to not remote it completely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: build An issue in the build type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants