Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust DefaultSecurityFilterChain Logging Level and Simplify Filter Logging #15096

Merged
merged 1 commit into from
May 23, 2024
Merged

Adjust DefaultSecurityFilterChain Logging Level and Simplify Filter Logging #15096

merged 1 commit into from
May 23, 2024

Conversation

baezzys
Copy link
Contributor

@baezzys baezzys commented May 19, 2024

Overview

This PR addresses issue #12218

  1. Changes the logging level of DefaultSecurityFilterChain from INFO to DEBUG to align with FilterChainProxy.
  2. Logs only the class names of filters instead of their full toString of filter.

@baezzys baezzys force-pushed the fix/logging-level-filterchain-info branch from 03f8784 to 7b06a6e Compare May 19, 2024 09:52
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 19, 2024
@baezzys baezzys force-pushed the fix/logging-level-filterchain-info branch 2 times, most recently from e642c4a to 8679f7a Compare May 19, 2024 10:05
jzheaux
jzheaux requested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @baezzys, this is helpful. I've left some feedback inline.

web/src/main/java/org/springframework/security/web/DefaultSecurityFilterChain.java Outdated Show resolved Hide resolved
@baezzys
Change DefaultSecurityFilterChain logging to DEBUG level and simplify…
5b77599 
… filter log

- Change DefaultSecurityFilterChain logging level from INFO to DEBUG to align with FilterChainProxy.
- Log filter class names instead of the toString() of filter.
@baezzys baezzys force-pushed the fix/logging-level-filterchain-info branch from 8679f7a to 5b77599 Compare May 21, 2024 00:38
@jzheaux jzheaux self-assigned this May 23, 2024
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels May 23, 2024
@jzheaux jzheaux added this to the 6.4.0-M1 milestone May 23, 2024
@jzheaux jzheaux merged commit ac9bdf5 into spring-projects:main May 23, 2024
4 checks passed
jzheaux added a commit that referenced this pull request May 23, 2024
@jzheaux
Polish DefaultSecurityFilterChain Logs
6956ed6 
Reuse String manipulation logic in Spring Framework
Compress whitespace

Closes gh-15096
@jzheaux
Copy link
Contributor

jzheaux commented May 23, 2024

Thanks, @baezzys! This is now merged into main. I also added a polish to reuse some of the String manipulation support in Spring Framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: web An issue in web modules (web, webmvc) status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement
Projects
None yet
Milestone
6.4.0-M1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@baezzys @jzheaux @spring-projects-issues