Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuration of SessionAuthenticationStrategy for CSRF #7083

Closed
wants to merge 1 commit into from
Closed

Allow configuration of SessionAuthenticationStrategy for CSRF #7083

wants to merge 1 commit into from

Conversation

samiconductor
Copy link
Contributor

Reasoning #5300 (comment)

Relates to #5300

@pivotal-issuemaster
Copy link

@samiconductor Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@samiconductor Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 5, 2019
@rwinch rwinch added in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 16, 2019
@rwinch rwinch self-assigned this Jul 16, 2019
@rwinch rwinch added this to the 5.2.0.RC1 milestone Jul 16, 2019
@rwinch
Copy link
Member

rwinch commented Jul 16, 2019

Thanks for the PR @samiconductor! This was merged via 09e8ae4

@rwinch rwinch closed this Jul 16, 2019
@samiconductor
Copy link
Contributor Author

Great! Thanks @rwinch. I wasn't sure what version to put for the @since docs. Looks like I should have put 5.2 instead of 5.1?

@rwinch
Copy link
Member

rwinch commented Jul 23, 2019

Ahh yes good catch @samiconductor! Can you send another PR to fix?

@samiconductor samiconductor mentioned this pull request Jul 24, 2019
Merged
@rwinch rwinch added in: docs An issue in Documentation or samples type: bug A general bug in: config An issue in spring-security-config type: enhancement A general enhancement and removed in: config An issue in spring-security-config type: enhancement A general enhancement in: docs An issue in Documentation or samples type: bug A general bug labels Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwinch rwinch

Labels
in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.M4
Development

Successfully merging this pull request may close these issues.
5 participants
@samiconductor @pivotal-issuemaster @rwinch @spring-projects-issues @mvitz