Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Removed Throws Clauses #7580

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Conversation

jzheaux
Copy link
Contributor

@jzheaux jzheaux commented Oct 29, 2019

In a recent clean-up, certain exceptions were removed from various
throws clauses.

This PR re-introduces throws clauses that are important for one of the
following reasons:

  1. It's a method on a public interface
  2. It's a method clearly designed for inheritance, for example, a
    method stub, an abstract method, or indicated as such in the docs.

Fixes gh-7541

In a recent clean-up, certain exceptions were removed from various
throws clauses.

This PR re-introduces throws clauses that are important for one of the
following reasons:

1. It's a method on a public interface
2. It's a method clearly designed for inheritance, for example, a
method stub, an abstract method, or indicated as such in the docs.

Fixes spring-projectsgh-7541
@jzheaux jzheaux requested a review from rwinch October 29, 2019 19:19
@jzheaux jzheaux added this to the 5.2.1 milestone Oct 29, 2019
@jzheaux jzheaux added in: config An issue in spring-security-config type: bug A general bug status: duplicate A duplicate of another issue labels Oct 29, 2019
@jzheaux jzheaux merged commit 5f17032 into spring-projects:master Oct 30, 2019
@jzheaux jzheaux deleted the gh-7541 branch October 30, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

throws Exception was removed from WebSecurityConfigurerAdapter#configure(WebSecurity)
2 participants