Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the ability to configure AuthoritiesMapper in Reactive OAuth2Login #8361

Closed
wants to merge 1 commit into from
Closed

Allow the ability to configure AuthoritiesMapper in Reactive OAuth2Login #8361

wants to merge 1 commit into from

Conversation

antonin-arquey
Copy link
Contributor

Allow the configuration of a custom GrantedAuthorityMapper for reactive OAuth2Login

  • Add setter in OidcAuthorizationCodeReactiveAuthenticationManager
    and OAuth2LoginReactiveAuthenticationManager

  • Use an available GrantedAuthorityMapper bean to configure the default ReactiveAuthenticationManager

Fixes gh-8324

@antonin-arquey
Add AuthoritiesMapper setter for reactive OAuth2Login
5475fcc 
Allow the configuration of a custom GrantedAuthorityMapper for reactive OAuth2Login

- Add setter in OidcAuthorizationCodeReactiveAuthenticationManager
  and OAuth2LoginReactiveAuthenticationManager

- Use an available GrantedAuthorityMapper bean to configure the default ReactiveAuthenticationManager

Fixes spring-projectsgh-8324
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 9, 2020
@antonin-arquey
Copy link
Contributor Author

CI failed with a BindException:

* What went wrong:
Execution failed for task ':spring-security-samples-javaconfig-form:appBeforeIntegrationTest'.
> java.util.concurrent.ExecutionException: java.net.BindException: Address already in use (Bind failed)

@rwinch
Copy link
Member

rwinch commented Apr 9, 2020

Thanks @antonin-arquey That appears to be related to gretty-gradle-plugin/gretty#139 which as been made more likely to happen now that we run our builds in parallel and using Gradle Enterprise cache (the cache means it often starts Gretty w/out the need to run tests).

@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 17, 2020
@jgrandja jgrandja modified the milestones: 5.4.x, 5.4.0.M1 Apr 17, 2020
@jgrandja
Copy link
Contributor

Thanks for the PR @antonin-arquey ! This is now in master.

@jgrandja jgrandja closed this Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0-M1
Development

Successfully merging this pull request may close these issues.

Allow the ability to configure AuthoritiesMapper in Reactive OAuth2Login
4 participants
@antonin-arquey @rwinch @jgrandja @spring-projects-issues