Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReactiveRedisSessionRepository Block when creating new session #2393

Closed
realzero0 opened this issue Aug 8, 2023 · 2 comments
Closed

ReactiveRedisSessionRepository Block when creating new session #2393

realzero0 opened this issue Aug 8, 2023 · 2 comments
Assignees
@marcusdacoregio
Labels
in: redis type: bug A general bug
Milestone
3.2.0-RC1

Comments

@realzero0
Copy link

java.util.UUID.randomUUID() is blocking

it might have to be changed to non-blocking way..

reactor/BlockHound#157

spring-session/spring-session-data-redis/src/main/java/org/springframework/session/data/redis/ReactiveRedisSessionRepository.java

Line 127 in 2d4233f

MapSession cached = new MapSession(this.sessionIdGenerator);

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 8, 2023
@quaff
Copy link
Contributor

quaff commented Aug 10, 2023

You can implement your own SessionIdGenerator after v3.2.0 released.

@marcusdacoregio marcusdacoregio self-assigned this Aug 10, 2023
@marcusdacoregio marcusdacoregio added type: bug A general bug in: redis and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 10, 2023
@marcusdacoregio marcusdacoregio added this to the 3.2.0-RC1 milestone Aug 10, 2023
quaff added a commit to quaff/spring-session that referenced this issue Aug 11, 2023
@quaff
Avoid blocking on session id generation
4a8c5c3 
see spring-projects#2393
@quaff quaff mentioned this issue Aug 11, 2023
Merged
@quaff
Copy link
Contributor

quaff commented Aug 11, 2023

@marcusdacoregio You missed #2396

marcusdacoregio pushed a commit that referenced this issue Aug 12, 2023
@quaff @marcusdacoregio
Avoid blocking on session id generation
b4e9af9 
see #2393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: redis type: bug A general bug
Projects
Spring Security Team
Archived in project
Milestone
3.2.0-RC1
Development

No branches or pull requests
4 participants
@quaff @marcusdacoregio @spring-projects-issues @realzero0