Header not set when response is bigger than bufferSize

[ralscha]

Hi

I'm fiddling with M1 and found two issues. I created a spring boot application that demonstrates the problem: https://github.com/ralscha/session

The application uses the HeaderHttpSessionStrategy and the response contains the x-auth-token header when the response is json and smaller than the default response buffer size of 8192. (http://localhost:8080/big)

The response is missing the x-auth-token header when the response is bigger than 8192 (http://localhost:8080/bigger)

The same happens when the StringHttpMessageConverter is used.
(http://localhost:8080/string). In this case the size does not matter. Even a small response does not contain the x-auth-token

As a workaround for the first problem I can simply increase the buffer

response.setBufferSize(9000);

Found no workaround for the String problem.

Ralph

[rwinch]

Thanks for reporting this issue. The problem was related to the fact that the OnCommitedResponseWrapper was not triggering when the response length was reached. Specifically the servlet specification states that the response should be considered committed if:

The amount of content specified in the setContentLength method of the response has been greater than zero and has been written to the response.

This means that the session header was not written until after the response was committed. Since the response was committed, the header was not actually included.

I have fixed this in master which should resolve your issue. I have verified that the fix resolves your sample application. If you get a chance, "Can you give the latest snapshot a try?"

[ralscha]

Hi. Thanks for the fix. The StringHttpMessageConverter url (http://localhost:8080/string) does work now, but a request to http://localhost:8080/bigger still does not contain the x-auth-token response header.
I use this snapshot: spring-session-1.0.0.BUILD-20140801.000037-56.jar

[rwinch]

@ralscha Thanks for the feedback. Locally I had tested this using Jetty as well (which all the URLs work on). It appears that somehow the URL for bigger has since broke again on Tomcat. I will look into resolving this. Thanks again for the report and double checking my work!

[rwinch]

@ralscha The second problem was related to the fact that the OnCommitedResponseWrapper was not triggering when the buffer size was reached. As alluded to, this only impacted Tomcat and not Jetty.

I have fixed this in master which should resolve your issue. I have verified the URLs on both Tomcat and Jetty now work. If you get a chance, "Can you give the latest snapshot a try?"

Thanks again for trying Spring Session and providing critical feedback!

[ralscha]

Hi. Looks good, the response always contains the header.
Thanks for your work.