Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JdkMongoSessionConverter should allow custom ClassLoader #431

Closed
rwinch opened this issue Mar 16, 2016 · 0 comments
Closed

JdkMongoSessionConverter should allow custom ClassLoader #431

rwinch opened this issue Mar 16, 2016 · 0 comments
Assignees
@rwinch
Labels
in: mongo-db type: enhancement A general enhancement
Milestone
1.2.0.RC1

Comments

@rwinch
Copy link
Member

rwinch commented Mar 16, 2016

This will allow swapping out the ClassLoader used for deserialization. This will ensure that Spring Session Mongo support works with Spring Boot's devtools (which uses a custom ClassLoader).

I haven't looked into this, but this might imply we can combine JacksonMongoSessionConverter and JdkMongoSessionConverter by simply using custom Serializer<Object> and Deserializer<Object>. Alternatively, we probably want to use the Converter APIs which would allow indirect use of Serializer<Object> and Deserializer<Object>

Relates to: spring-projects/spring-boot#3805

cc @jkubrynski
@rwinch rwinch added this to the 1.2.0 milestone Mar 16, 2016
@rwinch rwinch added the type: enhancement A general enhancement label Mar 16, 2016
@rwinch rwinch mentioned this issue Mar 16, 2016
Closed
@rwinch rwinch changed the title JdkMongoSessionConverter should use Spring's Serializer<Object> and Deserializer<Object> JdkMongoSessionConverter should allow custom ClassLoader Mar 16, 2016
jkubrynski added a commit to jkubrynski/spring-session that referenced this issue Mar 16, 2016
@jkubrynski
Fixes spring-projects#431 - Allow custom ClassLoader for serializatio…
054f0fc 
…n/deserialization
jkubrynski added a commit to jkubrynski/spring-session that referenced this issue Mar 16, 2016
@jkubrynski
Fixes spring-projects#431 - Fix checkstyle
0ace4fe
@rwinch rwinch self-assigned this Mar 17, 2016
@rwinch rwinch modified the milestones: 1.2.0.RC1, 1.2.0 Mar 17, 2016
@rwinch rwinch closed this as completed in 9014ac9 Mar 17, 2016
rwinch pushed a commit that referenced this issue Mar 17, 2016
Polish JdkMongoSessionConverter
b58ea03 
* Serializer/Deserializer -> Converter API
* Verify/Test null constructor arguments

Issue gh-431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: mongo-db type: enhancement A general enhancement
Projects
None yet
Milestone
1.2.0.RC1
Development

No branches or pull requests
1 participant
@rwinch