Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish related to testcontainers #2081

Merged
merged 1 commit into from Jan 23, 2023
Merged

Polish related to testcontainers #2081

merged 1 commit into from Jan 23, 2023

Conversation

eddumelendez
Copy link
Contributor

  • Use getHost instead of getContainerIpAddress
  • Rely on OracleContainer and it's improvements which involve the log
    wait strategy

@eddumelendez
Polish related to testcontainers
615b9f7 
* Use getHost instead of getContainerIpAddress
* Rely on OracleContainer and it's improvements which involve the log
wait strategy
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 15, 2022
@marcusdacoregio marcusdacoregio self-assigned this Dec 1, 2022
@marcusdacoregio marcusdacoregio added type: enhancement A general enhancement type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 1, 2022
@marcusdacoregio marcusdacoregio added this to the 3.1.0 milestone Dec 1, 2022
@marcusdacoregio marcusdacoregio added in: build An issue in the build and removed type: task A general task labels Jan 23, 2023
@marcusdacoregio marcusdacoregio modified the milestones: 3.1.0, 2.7.1 Jan 23, 2023
@marcusdacoregio marcusdacoregio merged commit 0dfc972 into spring-projects:2.7.x Jan 23, 2023
@marcusdacoregio
Copy link
Collaborator

Thanks @eddumelendez, this is now merged into 2.7.x and main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: build An issue in the build type: enhancement A general enhancement
Projects
None yet
Milestone
2.7.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eddumelendez @marcusdacoregio @spring-projects-issues