Provide Session Id Generation Strategy #2251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
quaff
force-pushed
the
patch-5
branch
5 times, most recently
from
270aba2
to
492e60f
Compare
vpavic
reviewed
Mar 8, 2023
|
@vpavic Switched from |
trydofor
reviewed
Mar 28, 2023
| return sessionIdGenerator.generateId(); | ||
| } | ||
|
|
||
| private static final SessionIdGenerator sessionIdGenerator; |
There was a problem hiding this comment.
Then what's your suggestion?
There was a problem hiding this comment.
At present, this PR can solve the problem easily.
I think static is structural problem (not this PR), I prefer PR #1547, using spring DI is better than SPI.
There was a problem hiding this comment.
That huge changeset is risky, this one is simple and reliable.
|
Closing in favor of #2286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GH-11