Use bean factory class loader for deserializing JDBC sessions #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * {@link ConversionService}. Applicable only with Spring 4.2.1 or later. | ||
| * @param classLoader the bean class loader | ||
| */ | ||
| public void setClassLoader(ClassLoader classLoader) { |
There was a problem hiding this comment.
User's might be a bit surprised to find out if the manually invoke setConversionService and then setClassLoader that the ConversionService is overridden.
Perhaps a better approach could be to remove the setClassLoader method and have the configuration class create a default ConversionService with the appropriate ClassLoader if the user has not explicitly provided one.
There was a problem hiding this comment.
Agreed @rwinch, that scenario came across my mind today as well.
rwinch
added
the
status: waiting-for-feedback
This commit addresses the issue with deserializing JDBC sessions in Spring Boot applications that use DevTools. Previously, such configuration would cause `ClassCastException` when deserializing JDBC sessions due to app class loader being used instead of restart class loader.
vpavic
force-pushed
the
fix-jdbc-classloading
branch
from
abf2ddd
to
71a7549
Compare
|
@rwinch I've updated the PR as per your suggestions. |
rwinch
pushed a commit
that referenced
this pull request
Sep 7, 2016
This commit addresses the issue with deserializing JDBC sessions in Spring Boot applications that use DevTools. Previously, such configuration would cause `ClassCastException` when deserializing JDBC sessions due to app class loader being used instead of restart class loader. Fixes gh-610
rwinch
pushed a commit
that referenced
this pull request
Sep 7, 2016
rwinch
pushed a commit
that referenced
this pull request
Sep 7, 2016
rwinch
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the issue with deserializing JDBC sessions in Spring Boot applications that use DevTools. Previously, such configuration would cause
ClassCastExceptionwhen deserializing JDBC sessions due to app class loader being used instead of restart class loader.See spring-projects/spring-boot#3805 for more background.