Parameterize SpringSessionBackedSessionRegistry
#700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpavic
force-pushed
the
parameterize-session-registry
branch
from
b2bb346
to
57b1d56
Compare
vpavic
force-pushed
the
parameterize-session-registry
branch
from
57b1d56
to
47438f8
Compare
vpavic
force-pushed
the
parameterize-session-registry
branch
from
47438f8
to
11d2639
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
SpringSessionBackedSessionRegistryworks againstFindByIndexNameSessionRepository, it should be parameterized with the sameExpiringSessiontype as the underlying session repository (similarly toSessionRepositoryFilter).The original motivation for this change is the fact that
SpringSessionBackedSessionRegistrycurrently cannot be constructed usingFindByIndexNameSessionRepository<? extends ExpiringSession>since its constructor expectsFindByIndexNameSessionRepository<ExpiringSession>. This is a problem since one typically needs to useFindByIndexNameSessionRepository<? extends ExpiringSession>in order to inject session repository.This was originally reported in this SO question.