decloakRequiresLineOfSight for maintenance #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This controls whether sight distance is used as a filter on proximity cloak checks, allowing for cheap implementations of the behaviour desired by FLOZi for s44 and myself for ZK. Added a missing comment for alwaysVisibleOverridesCloaked. See: * https://springrts.com/mantis/view.php?id=6306 * spring@ca1557c * https://springrts.com/mantis/view.php?id=6374
springraaar
pushed a commit
to springraaar/spring
that referenced
this pull request
Feb 16, 2023
- Listen to and adjust internal state on DualScreenMode and DualScreenMiniMapOnLeft changes - Add DualScreenMiniMapAspectRatio = [1]|0 to keep the map aspect ratio instead of stretching along the dual view - Perform fixes for proper viewport on: - GroundDrawer - BumpWater - ProjectileDrawer softening - LuaObjectDrawer (deferred pass on models) - Extract common viewports to: - GlobalRendering::LoadViewPort -> default viewport (posx, posy, sizex, sizey) - GlobalRendering::LoadDualViewPort -> dual viewport (dualposx, dualposy, dualsizex, dualsizey) - GL::GeometryBuffer::LoadViewPort -> deferred viewport (0, 0, sizex, sizey)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if separate PRs are desired, but I made the changes to test them so here it is. See #498