[VK] Updated global header component with some additional required styles #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-stevens
reviewed
Oct 13, 2021
toolkits/springernature/packages/springernature-header/scss/50-components/core.scss
Show resolved
Hide resolved
jon-stevens
reviewed
Oct 13, 2021
| @@ -1,5 +1,7 @@ | |||
| .c-header__content { | |||
| position: relative; | |||
| display: flex; | |||
| justify-content: space-between; | |||
|
|
|||
There was a problem hiding this comment.
The flex rule kicks in with the media query just below.
the following should be added to the README
@import '@springernature/brand-context/default/scss/10-settings/breakpoints';
@import '@springernature/brand-context/default/scss/30-mixins/media-query';```
jon-stevens
reviewed
Oct 13, 2021
toolkits/springernature/packages/springernature-header/scss/50-components/enhanced.scss
Outdated
Show resolved
Hide resolved
jon-stevens
reviewed
Oct 26, 2021
| @@ -54,6 +54,7 @@ Import the core styles into your main stylesheet | |||
| @import '@springernature/springernature-header/scss/10-settings/layout'; | |||
| @import '@springernature/springernature-user-details/scss/10-settings/typography'; // if including user-details data | |||
| @import '@springernature/springernature-user-details/scss/50-components/core'; // if including user-details data | |||
| @import '@springernature/brand-context/springernature/scss/10-settings/typography'; | |||
There was a problem hiding this comment.
This import should probably occur above scss/10-settings/typography
jon-stevens
reviewed
Oct 26, 2021
…https://github.com/springernature/frontend-toolkits into Updated_global_header_package_with_some_required_css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated some essential style for common global header package with comments