Fixed codacy complaints

(2793)
springfox · Nov 29, 2018 · 8238f24 · 8238f24
1 parent 1ff19f4
commit 8238f24
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 19 deletions.
diff --git a/.../main/java/springfox/documentation/spring/web/SpringIntegrationWebFluxRequestHandler.java b/.../main/java/springfox/documentation/spring/web/SpringIntegrationWebFluxRequestHandler.java
@@ -19,9 +19,7 @@
 package springfox.documentation.spring.web;
 
 import com.fasterxml.classmate.ResolvedType;
-import com.fasterxml.classmate.TypeResolver;
 import org.springframework.core.annotation.AnnotationUtils;
-import org.springframework.expression.spel.standard.SpelExpressionParser;
 import org.springframework.integration.http.inbound.BaseHttpInboundEndpoint;
 import org.springframework.web.method.HandlerMethod;
 import org.springframework.web.reactive.result.method.RequestMappingInfo;
@@ -43,9 +41,6 @@ public class SpringIntegrationWebFluxRequestHandler extends WebFluxRequestHandle
   private final HandlerMethod handlerMethod;
   private SpringIntegrationParametersProvider parametersProvider;
 
-  private final TypeResolver typeResolver = new TypeResolver();
-  private final SpelExpressionParser parser = new SpelExpressionParser();
-
   public SpringIntegrationWebFluxRequestHandler(
       HandlerMethodResolver methodResolver,
       RequestMappingInfo requestMapping,

diff --git a/...x/documentation/spring/web/plugins/SpringIntegrationDocumentationPluginsBootstrapper.java b/...x/documentation/spring/web/plugins/SpringIntegrationDocumentationPluginsBootstrapper.java
@@ -20,12 +20,9 @@
 package springfox.documentation.spring.web.plugins;
 
 import com.fasterxml.classmate.TypeResolver;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.event.ContextRefreshedEvent;
 import org.springframework.context.event.EventListener;
-import org.springframework.core.env.Environment;
 import org.springframework.stereotype.Component;
 import springfox.documentation.PathProvider;
 import springfox.documentation.schema.AlternateTypeRuleConvention;
@@ -45,7 +42,6 @@
  */
 @Component
 public class SpringIntegrationDocumentationPluginsBootstrapper extends AbstractDocumentationPluginsBootstrapper {
-  private static final Logger log = LoggerFactory.getLogger(SpringIntegrationDocumentationPluginsBootstrapper.class);
 
   private AtomicBoolean initialized = new AtomicBoolean(false);
 
@@ -57,8 +53,7 @@ public SpringIntegrationDocumentationPluginsBootstrapper(
       ApiDocumentationScanner resourceListing,
       TypeResolver typeResolver,
       Defaults defaults,
-      PathProvider pathProvider,
-      Environment environment) {
+      PathProvider pathProvider) {
     super(documentationPluginsManager, handlerProviders, scanned, resourceListing, defaults, typeResolver,
         pathProvider);
   }
@@ -80,6 +75,5 @@ public void contextRefreshedEventExecute() {
     if (initialized.compareAndSet(false, true)) {
       super.bootstrapDocumentationPlugins();
     }
-
   }
 }
diff --git a/...java/springfox/documentation/spring/web/plugins/SpringRestDocsOperationBuilderPlugin.java b/...java/springfox/documentation/spring/web/plugins/SpringRestDocsOperationBuilderPlugin.java
@@ -40,9 +40,9 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.nio.charset.Charset;
-import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
+import java.util.List;
 import java.util.Map;
 import java.util.Objects;
 import java.util.Set;
@@ -57,7 +57,7 @@
 @Order(Ordered.HIGHEST_PRECEDENCE + 1000)
 public class SpringRestDocsOperationBuilderPlugin implements OperationBuilderPlugin {
 
-  Logger LOG = LoggerFactory.getLogger(SpringRestDocsOperationBuilderPlugin.class);
+  private Logger LOG = LoggerFactory.getLogger(SpringRestDocsOperationBuilderPlugin.class);
 
   @Override
   public void apply(OperationContext context) {
@@ -114,8 +114,7 @@ private Function<Resource, RawHttpResponse<Void>> toRawHttpResponse() {
       try (InputStream resourceAsStream = new FileInputStream(resource.getFile())) {
         RawHttp rawHttp = new RawHttp();
         // must extract the body before the stream is closed
-        RawHttpResponse<Void> rawHttpResponse = rawHttp.parseResponse(resourceAsStream).eagerly();
-        return rawHttpResponse;
+        return (RawHttpResponse<Void>) rawHttp.parseResponse(resourceAsStream).eagerly();
       } catch (IOException e) {
         LOG.warn("Failed to read restdocs example for {} "
             + resource.getFilename() + " caused by: " + e.toString());
@@ -147,9 +146,9 @@ private Map<String, Header> toHeaders(RawHttpResponse<Void> parsedResponse) {
             o -> new Header(o.getKey(), "", new ModelRef("string"))));
   }
 
-  private ArrayList<Example> toExamples(RawHttpResponse<Void> parsedResponse) {
-    return new ArrayList<>(singletonList(new Example(getContentType(parsedResponse),
-        getBody(parsedResponse))));
+  private List<Example> toExamples(RawHttpResponse<Void> parsedResponse) {
+    return singletonList(new Example(getContentType(parsedResponse),
+        getBody(parsedResponse)));
   }
 
   private String getBody(RawHttpResponse<Void> parsedResponse) {