Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with not being able to import the project into eclipse using buildship (gradle integration). This is detailed in #1359.
Eclipse is able to have multiple projects unlike intellij which can only have one(i assume intellij sets the working directory to the root of this folder), eclipse sets it working directory to its workspace which is a different directory to its project directory. When it tries to find the last annotated tag via git its looking in the workspace directory which is not a git repo.
The fix simply adds the
-C <project root directory>
from the project so it can find the correct git repository.I have imported the project into intellij and eclipse, all existing tests pass when run from a terminal.