New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/spring integration support #2793
Merged
dilipkrish
merged 38 commits into
springfox:master
from
escalon:feature/spring-integration-support
Nov 29, 2018
Merged
Feature/spring integration support #2793
dilipkrish
merged 38 commits into
springfox:master
from
escalon:feature/spring-integration-support
Nov 29, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c, removed petstore and petstore-tests
…flux instead, first working version of webflux integration
…e supported in OpenApi 3, but not in OpenApi 2
…pring-integration-support
This was referenced Nov 23, 2018
Codecov Report
@@ Coverage Diff @@
## master #2793 +/- ##
============================================
- Coverage 94.78% 94.42% -0.36%
- Complexity 3161 3219 +58
============================================
Files 354 364 +10
Lines 8067 8300 +233
Branches 608 616 +8
============================================
+ Hits 7646 7837 +191
- Misses 271 305 +34
- Partials 150 158 +8
|
…rt' into feature/spring-integration-support
Thank you @dschulten, much appreciated 🙇. I did some re-formatting, to match current coding style, apologies for not sharing that publicly. At a high level
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do/fix?
Adds support for spring-integration-webmvc and spring-integration-webflux
Are there unit tests? If not how should this be manually tested?
There are unit tests, manual tests are possible with the related PR springfox/springfox-demos#57
Any background context you want to provide?
Some changes to the existing code were necessary.
In Spring-Integration, the
IntegrationRequestMappingHandlerMapping
andWebFluxIntegrationRequestMappingHandlerMapping
are initalized later than other HandlerMappings. Therefore I changedDocumentationPluginBootstrapper
so that it disables itself in favor ofSpringIntegrationDocumentationPluginBootstrapper
which fires onContextRefreshedEvent
, and let both derive from a common base class for the actual bootstrapping work. Also, the existing WebMvc and WebFluxRequestHandlerProvider
implementations needed to be told to leave the spring-integration handler mappings alone.The spring-restdocs support is realized by a standard plugin, the
SpringRestDocsOperationBuilderPlugin
.What are the relevant issues?
#550
#2754 closed in favor of this PR.
#797