Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added IsNullAnnotationPlugin #2862

Merged
merged 14 commits into from Jun 25, 2020
Merged

added IsNullAnnotationPlugin #2862

merged 14 commits into from Jun 25, 2020

Conversation

hsynkrtl
Copy link

This PR adds handling for bean validations @null annotation.

These properties are are mentioned as readOnly in swagger UI

This is related to #2861

@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited

Codecov Report

Merging #2862 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2862      +/-   ##
============================================
+ Coverage     92.93%   92.94%   +<.01%     
- Complexity     3512     3518       +6     
============================================
  Files           382      383       +1     
  Lines          9328     9336       +8     
  Branches        767      768       +1     
============================================
+ Hits           8669     8677       +8     
  Misses          471      471              
  Partials        188      188
Impacted Files Coverage Δ Complexity Δ
...idators/plugins/schema/IsNullAnnotationPlugin.java 100% <100%> (ø) 5 <5> (?)
...nfiguration/BeanValidatorPluginsConfiguration.java 100% <100%> (ø) 18 <1> (+1) ⬆️

@dilipkrish dilipkrish added the PR label Aug 3, 2019
@dilipkrish dilipkrish added this to the 3.0 milestone Aug 3, 2019
dilipkrish
dilipkrish requested changes Aug 3, 2019
View reviewed changes
Copy link
Member

@dilipkrish dilipkrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix the following

  • Checkstyle with unused import
  • Tests are not passing

@hsynkrtl
Copy link
Author

hsynkrtl commented Aug 5, 2019 •
edited

Done!

  • Checkstyle with unused import
  • Tests are not passing
  • Code coverage

@hsynkrtl hsynkrtl requested a review from dilipkrish June 25, 2020 19:21
@dilipkrish dilipkrish merged commit a903228 into springfox:master Jun 25, 2020
@dilipkrish
Copy link
Member

Thank you @hsynkrtl

@dilipkrish dilipkrish mentioned this pull request Jul 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilipkrish dilipkrish dilipkrish approved these changes

Assignees
No one assigned
Labels
PR
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsynkrtl @dilipkrish