Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2622 Error on use X-Forwarded-Prefix and ForwardedHeaderFilter #2897

Merged
merged 2 commits into from Aug 3, 2019
Merged

Fix #2622 Error on use X-Forwarded-Prefix and ForwardedHeaderFilter #2897

merged 2 commits into from Aug 3, 2019

Conversation

rainoko
Copy link

@rainoko rainoko commented Feb 8, 2019

PR will fix #2622

Covered with test

Detailed problem description #2622 (comment)

#2622

rainoko added 2 commits February 8, 2019 18:43
springfox#2622 new spring removes x-forwarded headers and changes req…
c418ad2 
…uest accordingly. So if adjuster not make any changes, request information should be correct already.
springfox#2622 request getHeaders must return enumeration
fccc5b6
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #2897 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2897      +/-   ##
============================================
+ Coverage     94.43%   94.44%   +0.01%     
- Complexity     3226     3228       +2     
============================================
  Files           364      364              
  Lines          8302     8304       +2     
  Branches        619      620       +1     
============================================
+ Hits           7840     7843       +3     
  Misses          304      304              
+ Partials        158      157       -1
Impacted Files Coverage Δ Complexity Δ
...documentation/swagger/common/HostNameProvider.java 89.47% <100%> (+1.23%) 5 <0> (+1) ⬆️
...ntation/swagger2/web/Swagger2ControllerWebMvc.java 92.3% <0%> (+3.84%) 8% <0%> (+1%) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Feb 8, 2019 •
edited

Codecov Report

Merging #2897 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2897      +/-   ##
============================================
+ Coverage     94.43%   94.44%   +0.01%     
- Complexity     3226     3228       +2     
============================================
  Files           364      364              
  Lines          8302     8304       +2     
  Branches        619      620       +1     
============================================
+ Hits           7840     7843       +3     
  Misses          304      304              
+ Partials        158      157       -1
Impacted Files Coverage Δ Complexity Δ
...documentation/swagger/common/HostNameProvider.java 89.47% <100%> (+1.23%) 5 <0> (+1) ⬆️
...ntation/swagger2/web/Swagger2ControllerWebMvc.java 92.3% <0%> (+3.84%) 8% <0%> (+1%) ⬆️

@rainoko
Copy link
Author

rainoko commented Feb 12, 2019

Is there hope for merge?

@vK44
Copy link

vK44 commented Mar 26, 2019

@dilipkrish any news on that?

@dilipkrish dilipkrish merged commit fccc5b6 into springfox:master Aug 3, 2019
@dilipkrish dilipkrish added the PR label Aug 3, 2019
@dilipkrish dilipkrish modified the milestones: Someday, 3.0 Aug 3, 2019
@dilipkrish dilipkrish mentioned this pull request Jul 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Error on use X-Forwarded-Prefix and ForwardedHeaderFilter
3 participants
@rainoko @vK44 @dilipkrish