Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3062 : Possibility to define order of produces and consumes attribute by Docket configuration #3063

Merged
merged 2 commits into from Aug 3, 2019

Conversation

wojciech-soltys
Copy link

What's this PR do/fix?

#3062

Are there unit tests? If not how should this be manually tested?

Manually tested by changed Docket configuration within Swagger2SpringBoot class (added below attributes):
.produces(new LinkedHashSet<>(Arrays.asList("application/json", "application/xml"))) .consumes(new LinkedHashSet<>(Arrays.asList("application/json", "application/xml"))

and next generating JSON documentation by accessing http://localhost:8080/v2/api-docs .

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #3063 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3063   +/-   ##
=========================================
  Coverage     92.94%   92.94%           
  Complexity     3462     3462           
=========================================
  Files           375      375           
  Lines          9214     9214           
  Branches        758      758           
=========================================
  Hits           8564     8564           
  Misses          464      464           
  Partials        186      186
Impacted Files Coverage Δ Complexity Δ
.../service/contexts/DocumentationContextBuilder.java 100% <100%> (ø) 34 <0> (ø) ⬇️
...ngfox/documentation/spring/web/plugins/Docket.java 100% <100%> (ø) 40 <0> (ø) ⬇️

1 similar comment
@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #3063 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3063   +/-   ##
=========================================
  Coverage     92.94%   92.94%           
  Complexity     3462     3462           
=========================================
  Files           375      375           
  Lines          9214     9214           
  Branches        758      758           
=========================================
  Hits           8564     8564           
  Misses          464      464           
  Partials        186      186
Impacted Files Coverage Δ Complexity Δ
.../service/contexts/DocumentationContextBuilder.java 100% <100%> (ø) 34 <0> (ø) ⬇️
...ngfox/documentation/spring/web/plugins/Docket.java 100% <100%> (ø) 40 <0> (ø) ⬇️

@dilipkrish dilipkrish added the PR label Aug 3, 2019
@dilipkrish
Copy link
Member

Thanks for catching that!

@dilipkrish dilipkrish merged commit 4d4577b into springfox:master Aug 3, 2019
@dilipkrish dilipkrish added this to the 3.0 milestone Aug 3, 2019
@wojciech-soltys wojciech-soltys deleted the feature/3062 branch August 5, 2019 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants